Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Upgrade to latest dependencies #15794

Open
wants to merge 2 commits into
base: release-1.16
Choose a base branch
from

Conversation

knative-automation
Copy link
Contributor

update knative.dev/hack to use latest GKE version -dsimansk

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

bumping knative.dev/hack 6cb0feb...b5e4ff8:
  > b5e4ff8 [release-1.16] Update GKE version to 1.29 (# 415)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-release-1.16 branch from f376802 to 59fe103 Compare February 27, 2025 10:31
@knative-prow knative-prow bot requested a review from a team February 27, 2025 10:31
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2025
Copy link

knative-prow bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (674f624) to head (273b36b).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16   #15794   +/-   ##
=============================================
  Coverage         83.57%   83.58%           
=============================================
  Files               219      219           
  Lines             17462    17462           
=============================================
+ Hits              14594    14595    +1     
+ Misses             2499     2494    -5     
- Partials            369      373    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Feb 27, 2025

{ error creating the clusters: error creating clusters: error creating cluster: exit status 1, output: "Default change: VPC-native is the default mode during cluster creation for versions greater than 1.21.0-gke.1500. To create advanced routes based clusters, please pass the --no-enable-ip-alias flag\nDefault change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the --location-policy flag.\nNote: Your Pod address range (--cluster-ipv4-cidr) can accommodate at most 1008 node(s).\nERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=No valid versions with the prefix "1.28" found.\n"}

@skonto
Copy link
Contributor

skonto commented Feb 27, 2025

@dsimansk I guess it is the goal to fix this with your update? I should just override the failing tests right?

@dsimansk
Copy link
Contributor

@dsimansk I guess it is the goal to fix this with your update? I should just override the failing tests right?

Yes, but the tests should be fixed already. Other issue might be that there's explicit version string in e2e test setups. It should be bumped too.

@dsimansk
Copy link
Contributor

Here:

initialize --num-nodes=4 --enable-ha --cluster-version=1.28 "$@"

@dsimansk
Copy link
Contributor

Fixed in: 273b36b

Copy link

knative-prow bot commented Feb 27, 2025

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
istio-latest-no-mesh-tls_serving_release-1.16 273b36b link true /test istio-latest-no-mesh-tls
upgrade-tests_serving_release-1.16 273b36b link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants