-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.16] Upgrade to latest dependencies #15794
base: release-1.16
Are you sure you want to change the base?
[release-1.16] Upgrade to latest dependencies #15794
Conversation
bumping knative.dev/hack 6cb0feb...b5e4ff8: > b5e4ff8 [release-1.16] Update GKE version to 1.29 (# 415) Signed-off-by: Knative Automation <[email protected]>
f376802
to
59fe103
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knative-automation The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #15794 +/- ##
=============================================
Coverage 83.57% 83.58%
=============================================
Files 219 219
Lines 17462 17462
=============================================
+ Hits 14594 14595 +1
+ Misses 2499 2494 -5
- Partials 369 373 +4 ☔ View full report in Codecov by Sentry. |
{ error creating the clusters: error creating clusters: error creating cluster: exit status 1, output: "Default change: VPC-native is the default mode during cluster creation for versions greater than 1.21.0-gke.1500. To create advanced routes based clusters, please pass the |
@dsimansk I guess it is the goal to fix this with your update? I should just override the failing tests right? |
Yes, but the tests should be fixed already. Other issue might be that there's explicit version string in e2e test setups. It should be bumped too. |
Here: Line 31 in 674f624
|
Fixed in: 273b36b |
@knative-automation: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
update knative.dev/hack to use latest GKE version -dsimansk
/cc knative/serving-writers
/assign knative/serving-writers
Produced by: knative-extensions/knobots/actions/update-deps