Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarize all nightlies and release jobs #3559

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Notarize all nightlies and release jobs #3559

merged 3 commits into from
Oct 10, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Oct 6, 2022

@knative-prow knative-prow bot requested review from cardil and krsna-m October 6, 2022 16:29
@knative-prow
Copy link

knative-prow bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Oct 6, 2022

Please run ./hack/update-codegen.sh. is failing codegen verify

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2022

Fixed

@krsna-m
Copy link
Contributor

krsna-m commented Oct 6, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@upodroid upodroid closed this Oct 7, 2022
@upodroid upodroid reopened this Oct 7, 2022
@upodroid
Copy link
Member Author

/easycla

@knative-prow knative-prow bot merged commit c590ed3 into knative:main Oct 10, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 10, 2022

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kn-plugin-admin-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-admin-main.gen.yaml
  • key kn-plugin-event-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-main.gen.yaml
  • key kn-plugin-operator-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-operator-main.gen.yaml
  • key kn-plugin-quickstart-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-quickstart-main.gen.yaml
  • key kn-plugin-service-log-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-service-log-main.gen.yaml
  • key kn-plugin-source-kafka-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-source-kafka-main.gen.yaml
  • key kn-plugin-source-kamelet-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-source-kamelet-main.gen.yaml
  • key client-main.gen.yaml using file prow/jobs/generated/knative/client-main.gen.yaml
  • key func-main.gen.yaml using file prow/jobs/generated/knative/func-main.gen.yaml

In response to this:

Part of knative/infra#99

This has been running successfully since yesterday
https://prow.knative.dev/view/gs/knative-prow/logs/nightly_kn-plugin-quickstart_main_periodic/1577952327749341184

/cc @kvmware @cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants