feat: wasi platform build #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 2, 2022 20:40
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
imjasonh
reviewed
Sep 8, 2022
| @@ -0,0 +1,66 @@ | |||
| name: Integration test for wasi | |||
.github/workflows/wasi.yaml
Outdated
|
|
||
| # run a nested podman container to use annotations (could be removed once docker is able to specify annotations on containers) | ||
| docker run --priviliged \ | ||
| -v /tmp/crun/crun:/usr/bin/crun \ |
There was a problem hiding this comment.
Is there a way to just run crun directly, instead of having to run it in a container?
There was a problem hiding this comment.
I think it's easier to run everything inside a container, because automatically creating OCI bundles is kinda clunky. This approach makes it a bit easier.
added 6 commits
September 9, 2022 13:47
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
|
@imjasonh I did some local testing on the integration tests, they should be working by now. |
added 2 commits
September 13, 2022 19:27
Signed-off-by: Höhl, Lukas <[email protected]>
Signed-off-by: Höhl, Lukas <[email protected]>
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second iteration, for more information see #738
This PR implements the scenario described in #675 by using tinygo as the builder for target WASI.
Documentation is not yet done, but can be created if this feature is wanted.
SBOM generation is currently not implemented, since tinygo doesn't produce the same buildInfo that go does.
Signed-off-by: Höhl, Lukas [email protected]