Prevent "not implemented" error being logged in jsdom and general repository maintenance #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing
is-emoji-supported
in jsdom (Jest), the following is logged viaconsole.error
:While this does not cause tests to fail, people may waste time trying to fix this error. In both of the repositories where I'm seeing this error, it's not possible to suppress the error via Jest module mocking. So it made the most sense to fix it here.
I set up Jest in the repository so I could write a test that asserts
console.error
is not called when importingis-emoji-supported.ts
.General repository maintenance changes:
devDependencies
to the latest version.yarn.lock
andpackage-lock.json
, which is confusing for developers who are new to the project. I removedyarn.lock
since the README said to run tests usingnpm
.By the way
If you like these changes and need help maintaining this repository, feel free to add me as a contributor. Just saying this because I cannot tell if this repository is abandoned, or if there has just been no recent work on it because there were no issues.