drop info #223
Closed
drop info #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8674fa5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3aae0374.workers-ogi.pages.dev |
| Branch Preview URL: | https://feat-drop-info.workers-ogi.pages.dev |
|
Well that is not true 😅 |
Which part is not true? 👀 items -> max ? |
vikiival
requested changes
Dec 7, 2023
| `https://waifu-me.kodadot.workers.dev/drops/${id}`, | ||
| ) | ||
| const drop = (await dropData.json()) as DropItem | ||
| const isPaid = drop.type === 'paid' |
There was a problem hiding this comment.
This one.
I do not currently hold price per mint but this one will be untrue for generative and paid :)
There was a problem hiding this comment.
Based on the code implemented before, we will determine whether it is paid based on type, and then determine the paid price based on meta.
Maybe the implementation for paid drop will change in the future, I would close this PR for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #218 (comment)
free: [Free drop]
paid: [$ 10 drop]