-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/my new joke #94
Open
dwshore
wants to merge
4
commits into
kodecocodes:master
Choose a base branch
from
dwshore:feature/my-new-joke
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwshore
commented
Jan 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good times!
@@ -33,6 +33,9 @@ struct JokeStore { | |||
Joke(description: "Why don't programmers like being outside?", punchline: "Because there's too many bugs"), | |||
Joke(description: "Why don't bachelors like Git?", punchline: "Because they are afraid to commit."), | |||
Joke(description: "What does the father play with his son?", punchline: "Try Catch"), | |||
Joke(description: "Be careful with functions that return a value...", punchline: "In fact, I would just a void them."), | |||
Joke(description: "How did pirates collaborate before computers?", punchline: "Pier to pier networking"), | |||
Joke(description: "Why does Yoda's code always crash?", punchline: "Because there is no try."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Star Wars fans out there...
Have created a Travis CI account. Trying again. |
Not sure why my commit created this, but hoping it's what is causing my PR's to fail the Travis CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1 . Adds some new dad jokes.