Correct bug that hid "Authors will be notified" comment message

Reported by Christina Pöpper
kohler · Sep 25, 2024 · 0015dba · 0015dba
1 parent 9ff849b
commit 0015dba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/scripts/script.js b/scripts/script.js
@@ -1795,7 +1795,6 @@ function render_alert(ml) {
 }
 
 function redundant_item(mi, ul) {
-    let xm;
     return mi.message == null
         || mi.message === ""
         || (!mi.landmark
@@ -7112,7 +7111,7 @@ function cmt_visibility_change() {
         vis = form.elements.visibility,
         topic = form.elements.topic,
         is_paper = topic && topic.value === "paper" && (!vis || vis.value !== "admin");
-    if (vis && vis.type === "select" && !form.elements.by_author) {
+    if (vis && vis.type === "select-one" && !form.elements.by_author) {
         const vishint = vis.closest(".entryi").querySelector(".f-d"),
             would_auvis = is_paper
                 || hotcrp.status.myperm[topic && topic.value === "dec" ? "some_author_can_view_decision" : "some_author_can_view_review"],

diff --git a/scripts/settings.js b/scripts/settings.js
@@ -140,7 +140,7 @@ function settings_disable_children(e) {
         this.removeAttribute("name"); // do not submit with form
         if (this.type === "checkbox" || this.type === "radio" || this.type === "button")
             this.disabled = true;
-        else if (this.type !== "select")
+        else if (this.type !== "select-one")
             this.readonly = true;
         removeClass(this, "ui");
         this.removeAttribute("draggable");