Don't put garbage in redirection URLs.

kohler · Dec 10, 2023 · 4815e00 · 4815e00
1 parent 4ddb21f
commit 4815e00
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/pages/p_bulkassign.php b/src/pages/p_bulkassign.php
@@ -188,7 +188,7 @@ function print() {
         // redirect if save cancelled
         if (isset($qreq->saveassignment)
             && isset($qreq->cancel)) {
-            unset($qreq->saveassignment);
+            unset($qreq->saveassignment, $qreq->p, $qreq->pap);
             $conf->redirect_self($qreq); // should not return
             return;
         }
@@ -199,6 +199,7 @@ function print() {
             && isset($qreq->data)
             && $qreq->assignment_size_estimate < 1000
             && $this->complete_assignment(null)) {
+            unset($qreq->saveassignment, $qreq->p, $qreq->pap);
             $conf->redirect_self($qreq);
             return;
         }