Skip to content

Commit

Permalink
The VIEWALLREV track should not constrain co-reviewers.
Browse files Browse the repository at this point in the history
  • Loading branch information
kohler committed Oct 12, 2023
1 parent 50d89c4 commit d72fd19
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/contact.php
Original file line number Diff line number Diff line change
Expand Up @@ -3846,7 +3846,9 @@ private function seerev_setting(PaperInfo $prow, $rbase, $rights) {
}
$round = $rbase ? $rbase->reviewRound : "max";
$s = $this->conf->round_setting($rights->allow_pc ? "viewrev" : "viewrev_ext", $round) ?? 0;
if ($s > 0 && !$this->conf->check_reviewer_tracks($prow, $this, Track::VIEWALLREV)) {
if ($s > 0
&& !$rights->reviewType
&& !$this->conf->check_reviewer_tracks($prow, $this, Track::VIEWALLREV)) {
$s = 0;
}
return $s;
Expand Down

0 comments on commit d72fd19

Please sign in to comment.