Feature request: Add option to hide all paper details from conflicted PC members #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! This is a good idea but needs a different implementation. The place to put this logic is Changes to aspects of HotCRP rights are very important to test as well. |
|
Dear EddieThank you for you feedback. I will hopefully find time to look at this sometime soon.On 6 Oct 2024, at 14:54, Eddie Kohler ***@***.***> wrote:
Thanks!! This is a good idea but needs a different implementation. The place to put this logic is Contact::rights and Contact::can_view_paper, in src/contact.php. In particular, I think you want to add another clause to the setting of $allow_pc_broad in Contact::rights. Something like
$allow_pc_broad = $allow_administer
|| ($isPC
&& ($ci->conflictType <= CONFLICT_MAXUNCONFLICTED || $this->conf->pc_hideconflicts));
Changes to aspects of HotCRP rights are very important to test as well.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
kohler
reviewed
Oct 6, 2024
src/conference.php
Outdated
| @@ -257,6 +257,9 @@ class Conf { | |||
| const BLIND_ALWAYS = 2; | |||
| const BLIND_UNTILREVIEW = 3; | |||
|
|
|||
| const PC_HIDECONFLICTED_NO = 0; | |||
| const PC_HIDECONFLICTED_YES = 1; | |||
|
|
|||
There was a problem hiding this comment.
Better to have just a boolean (no explicit constants)
src/pages/p_doc.php
Outdated
| if(!$user->privChair && $prow->conf->settings["pc_hideconflicted"] == 1 && $prow->has_conflict($user) && !$row->has_author($pl->user)) { | ||
| self::error("403 Forbidden", MessageItem::error("<5>Access denied to conflicting submission."), $qreq); | ||
| } | ||
|
|
There was a problem hiding this comment.
This should not be needed. The immediately preceding logic should suffice. If you want a special error message you could implement that logic in src/failurereason.php.
src/pages/p_paper.php
Outdated
| $pt->print_paper_info(); | ||
| if($pt->user->privChair || !($pt->conf->settings["pc_hideconflicted"] == 1 && $pt->prow->has_conflict($pt->user) && !$pt->prow->has_author($pt->user))) { | ||
| $pt->print_paper_info(); | ||
| } |
src/papercolumn.php
Outdated
| if(!$pl->user->privChair && $pl->conf->settings["pc_hideconflicted"] == 1 && $row->has_conflict($pl->user) && !$row->has_author($pl->user)) { | ||
| return "#{$row->paperId}"; | ||
| } | ||
|
|
There was a problem hiding this comment.
Don't want this (logic should be in can_view_paper)
src/papercolumn.php
Outdated
| if ($this->want_decoration | ||
| && ($pl->row_tags !== "" || $pl->row_tags_override !== "")) { | ||
| $t .= $row->decoration_html($pl->user, $pl->row_tags, $pl->row_tags_override); | ||
| } |
There was a problem hiding this comment.
Don't want this (logic again should be in can_view_paper)
src/papercolumn.php
Outdated
| if($pl->conf->settings["pc_hideconflicted"] == 1 && $row->has_conflict($pl->user) && !$row->has_author($pl->user)) { | ||
| return ""; | ||
| } | ||
|
|
src/papertable.php
Outdated
| if (!$paperTable->user->privChair && $prow->has_conflict($paperTable->user) && !$prow->has_author($paperTable->user)) { | ||
| $paperConflicted = true; | ||
| } | ||
|
|
AGrillenberger
force-pushed
the
hide-conflicted-papers
branch
from
f9e9a6d to
5f6ede6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our conferences, it is usual that PC members who have a conflict with a paper, cannot see anything about these papers (no abstract, title, PDF). As this was not possible yet with HotCRP, I implemented this by...
pc_hide_conflicted_papers(yes/no)