Skip to content

Commit

Permalink
fix: convert headers to dict before exposing to users (numaproj#151)
Browse files Browse the repository at this point in the history
Signed-off-by: Yashash H L <[email protected]>
  • Loading branch information
yhl25 authored Apr 10, 2024
1 parent 51a1b37 commit af095a1
Show file tree
Hide file tree
Showing 15 changed files with 27 additions and 19 deletions.
2 changes: 1 addition & 1 deletion pynumaflow/mapper/servicer/async_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async def MapFn(
value=request.value,
event_time=request.event_time.ToDatetime(),
watermark=request.watermark.ToDatetime(),
headers=request.headers,
headers=dict(request.headers),
),
)
except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion pynumaflow/mapstreamer/servicer/async_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async def MapStreamFn(
value=request.value,
event_time=request.event_time.ToDatetime(),
watermark=request.watermark.ToDatetime(),
headers=request.headers,
headers=dict(request.headers),
),
):
yield mapstream_pb2.MapStreamResponse(result=res)
Expand Down
5 changes: 3 additions & 2 deletions pynumaflow/proto/mapper/map_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pynumaflow/proto/mapstreamer/mapstream_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pynumaflow/proto/reducer/reduce_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pynumaflow/proto/sideinput/sideinput_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pynumaflow/proto/sinker/sink_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pynumaflow/proto/sourcer/source_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pynumaflow/proto/sourcetransformer/transform_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pynumaflow/reducer/servicer/async_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async def datum_generator(
value=d.payload.value,
event_time=d.payload.event_time.ToDatetime(),
watermark=d.payload.watermark.ToDatetime(),
headers=d.payload.headers,
headers=dict(d.payload.headers),
),
)
yield reduce_request
Expand Down
1 change: 1 addition & 0 deletions pynumaflow/reducestreamer/servicer/async_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ async def datum_generator(
value=d.payload.value,
event_time=d.payload.event_time.ToDatetime(),
watermark=d.payload.watermark.ToDatetime(),
headers=dict(d.payload.headers),
),
)
yield reduce_request
Expand Down
2 changes: 1 addition & 1 deletion pynumaflow/sinker/servicer/async_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async def datum_generator(
value=d.value,
event_time=d.event_time.ToDatetime(),
watermark=d.watermark.ToDatetime(),
headers=d.headers,
headers=dict(d.headers),
)
yield datum

Expand Down
2 changes: 1 addition & 1 deletion pynumaflow/sinker/servicer/sync_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def datum_generator(request_iterator: Iterable[sink_pb2.SinkRequest]) -> Iterabl
value=d.value,
event_time=d.event_time.ToDatetime(),
watermark=d.watermark.ToDatetime(),
headers=d.headers,
headers=dict(d.headers),
)
yield datum

Expand Down
2 changes: 1 addition & 1 deletion pynumaflow/sourcer/servicer/sync_servicer.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __invoke_source_read_stream(self, req: ReadRequest):
keys=msg.keys,
offset=msg.offset.as_dict,
event_time=event_time_timestamp,
headers=msg.headers,
headers=dict(msg.headers),
)
except Exception as err:
_LOGGER.critical("User-Defined Source ReadError ", exc_info=True)
Expand Down
2 changes: 1 addition & 1 deletion pynumaflow/sourcetransformer/servicer/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def SourceTransformFn(
value=request.value,
event_time=request.event_time.ToDatetime(),
watermark=request.watermark.ToDatetime(),
headers=request.headers,
headers=dict(request.headers),
),
)
except Exception as err:
Expand Down

0 comments on commit af095a1

Please sign in to comment.