Updated the property path for track key to Traktor 3.2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Key section on the Kontrol S5 shows "ERR", instead of keyDisplay. Changing Prefs.qml middleCenterText to show "key" works.; changing to "keyText", also works. Tested on S5 - Traktor 3.2.0 (60) |
|
@kokernutz How about allowing this to merge (for now) as it mostly fixes the key issues in the browser and deck views? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
Also changes the displayed value for deck info option 17 ("key") to the current key, taking pitch and key bending into account.
Tested on S5 - Traktor 3.2.0