-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply check functions to fft functions #130
Apply check functions to fft functions #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main question is about whether to enable the checks in non-debug mode or not ?
First of all, thank you for your reviews. Actually, we need it to enable for non-debug mode (different from Kokkos). The point is that if we execute an internal fft library without satisfying the conditions, we may get unexpected errors from the library. I would like to let users know that input data are invalid with the appropriate error messages. |
Improves #80
This PR aims at replacing runtime
assert
withKOKKOSFFT_EXPECTS
. Adding morestatic_assertions
if applicable.Modifications are applied to source code under
fft/src
andfft/unit_test
.Following modifications are made
KOKKOSFFT_EXPECTS
fromKokkosFFT_utils.hpp
toKokkosFFT_asserts.hpp
are_valid_axes
function where it is applicableKOKKOSFFT_EXPECTS
to some if else conditional (throwstd::runtime_error
in the case ofelse
)is_complex<ViewType>::value
withis_complex_v<ViewType>