Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unresolved doxygen for N-dimensional FFT APIs #143

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

yasahi-hpc
Copy link
Collaborator

This PR aims at fixing docstrings bugs from #141
As a temporary solution, we introduce a macro for doxygen which can be resolved. See kokkos/kokkos-kernels#1319 for detail.

@yasahi-hpc yasahi-hpc self-assigned this Oct 1, 2024
@yasahi-hpc yasahi-hpc added bug Something isn't working documentation Improvements or additions to documentation labels Oct 1, 2024
@yasahi-hpc yasahi-hpc requested a review from tpadioleau October 1, 2024 09:14
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fft/src/KokkosFFT_Transform.hpp Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

@tpadioleau Thank you for your review.

@yasahi-hpc yasahi-hpc merged commit 25469cd into main Oct 1, 2024
21 checks passed
@yasahi-hpc yasahi-hpc deleted the fix-doxygen branch October 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants