Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version file #251

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

add version file #251

wants to merge 2 commits into from

Conversation

nmm0
Copy link
Contributor

@nmm0 nmm0 commented Apr 4, 2023

This adds a VERSION file. Also, CMake will read the version from the file and it's easily read from scripts, so it will be easier to keep updated in releases

I therefore bumped the version to 0.5.0 since that's the last release (we forgot to update it from 0.4.0)

@nmm0 nmm0 requested review from dalg24 and crtrott April 4, 2023 21:43
@dalg24
Copy link
Member

dalg24 commented Apr 4, 2023

This adds a VERSION file. Also, CMake will read the version from the file and it's easily read from scripts, so it will be easier to keep updated in releases

I don't get the argument this will be easier.

@nmm0
Copy link
Contributor Author

nmm0 commented Apr 4, 2023

This adds a VERSION file. Also, CMake will read the version from the file and it's easily read from scripts, so it will be easier to keep updated in releases

I don't get the argument this will be easier.

You don't need to parse CMake to get the version from a tarball in a script.

I did some sleuthing and it's not super common to have a VERSION file, but pytorch does it (called version.txt) and CUDA has a version.json (which has a version for each component) in their tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants