Msvc layout stride fixes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
commented
Jan 4, 2024
| @@ -88,7 +88,7 @@ struct layout_stride { | |||
| : private detail::__no_unique_address_emulation< | |||
| detail::__compressed_pair< | |||
| Extents, | |||
| std::array<typename Extents::index_type, Extents::rank()> | |||
| detail::possibly_empty_array<typename Extents::index_type, Extents::rank()> | |||
There was a problem hiding this comment.
see below: the base_t typedef was already using possibly_empty_array. This needed to change, because std::array is not actually empty for rank == 0
crtrott
commented
Jan 4, 2024
| @@ -231,7 +231,7 @@ static_assert(_MDSPAN_CPLUSPLUS >= MDSPAN_CXX_STD_14, "mdspan requires C++14 or | |||
| #endif | |||
|
|
|||
| #ifndef MDSPAN_CONDITIONAL_EXPLICIT | |||
| # if MDSPAN_HAS_CXX_20 && !defined(_MDSPAN_COMPILER_MSVC) | |||
There was a problem hiding this comment.
effectively this impacted some tests which didn't guard the convertibility tests correctly for C++20 & MSVC. But with current MSVC this just works anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.