-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom buttons #435
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 19.57% 20.91% +1.33%
==========================================
Files 6 8 +2
Lines 475 483 +8
Branches 104 104
==========================================
+ Hits 93 101 +8
Misses 379 379
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Hi! Thanks for the PR. I will check it soon as possible. |
If we introduced a new component angular-editor/projects/angular-editor/src/lib/angular-editor-toolbar.component.html Line 2 in df050a9
wouldn't that break compatibility for the future? |
Why do you think it should break compatibility? I do not think so. Also, I refactor the toolbar as you wish :). I do not think, that Encapsulation.None is ideal, but you used it also in the project. |
I created PR for support for custom buttons in the toolbar. In our company, we needed this functionality and thus we needed to choose to pick fate-editor instead of this. But Fate is not under maintenance.
Usage is simple: You can define your custom buttons with custom actions using executeCommandFn. It accepts commands from execCommand.
The first argument of this method is aCommandName and the second argument is aValueArgument. Example shows a button that adds Angular editor logo into the editor.