Fix country updating and missing dialing codes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NPE when changing flags with an invalid country code input Fix flag being wrongly updated for duplicate dial codes Add missing dialing codes
priitd
force-pushed
the
fix-country-updating
branch
from
cbade20 to
c845022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing dialing codes for which a flag and name exists, but the dialing code did not and fixes the following bugs:
Country being updated wrongly in case of duplicate dial codes. For example, US and Canada both have the dial code 1, but selecting Canada and updating the number automatically selected the US flag instead. The new behavior is that if a selected country with the same dial code already exists, then the country flag will not be updated.
NPE when selecting a country flag while the input contained an invalid dial code, eg. +9. The nev behaviour is that the invalid content will be removed.