STONEBLD-2648: fix OWNERS files #1273
Conversation
tisutisu
force-pushed
the
update_owners
branch
from
66e012e to
9fe2927
Compare
tisutisu
force-pushed
the
update_owners
branch
from
9fe2927 to
701c873
Compare
| @@ -0,0 +1,4 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
Will it mean that we'll be pinged to all PRs in the repo even the tasks we don't have relation to?
There was a problem hiding this comment.
It is kind of default.. if some task don't have OWNERS file..and other sub-directories like pipelines or .tekton where OWNERS file are not there.. then it will fall back to OWNERS file in the root for assigning reviews.
| @@ -1,2 +1 @@ | |||
|
|
|||
| opdev | |||
| #opdev | |||
There was a problem hiding this comment.
I think the OWNERS should be @skattoju (anyone else?)
There was a problem hiding this comment.
Does it have to be github usernames ? We have @preflight-dev in slack that pings preflight team members. I had initially set it as opdev to reflect this github org https://github.com/opdev Other team members include @acornett21 @bcrochet @komish
There was a problem hiding this comment.
Updated the owners file with github id's shared.
| - tkdchen | ||
| - tisutisu | ||
| - tnevrlka | ||
| - MartinBasti |
There was a problem hiding this comment.
Should we also add the gold team as the prefetch task maintainers? At least a few additional members apart from @MartinBasti? E.g. @eskultety @brunoapimentel @taylormadore
There was a problem hiding this comment.
okay added them in the build-team alias.
tisutisu
force-pushed
the
update_owners
branch
from
701c873 to
257ef65
Compare
| @@ -1,2 +1,5 @@ | |||
| approvers: | |||
| - skattoju | |||
There was a problem hiding this comment.
I think you should add another devs that are mentioned in the comment
There was a problem hiding this comment.
Updated now. Thanks.
Use correct format for the OWNERS files
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.