Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add renovate customManager to update buildah image #1280

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Aug 12, 2024

STONEBLD-2661

buildah image is also specified in the .spec.stepTemplate.env. This custom manager updates the buildah image there.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

STONEBLD-2661

buildah image can also be specified in the .spec.stepTemplate.env, for
instance inside task task/buildah-remote/0.1/buildah-remote.yaml. This
custom manager updates the buildah image there.

Signed-off-by: Chenxiong Qi <[email protected]>
@tkdchen tkdchen force-pushed the STONEBLD-2661-update-buildah-image branch from a75aa45 to ebd5539 Compare August 12, 2024 07:36
Copy link
Collaborator

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adding this change here work?

@tkdchen
Copy link
Contributor Author

tkdchen commented Aug 12, 2024

Will adding this change here work?

Based on my current understanding of renovate, I don't think so. The packageRules defines how renovate handles a package (a dependency) detected by the tekton manager.

This custom manager is an addition to the tekton manager to cover the value fields.

@tkdchen tkdchen added this pull request to the merge queue Aug 12, 2024
Merged via the queue into konflux-ci:main with commit e49a405 Aug 12, 2024
9 checks passed
@tkdchen tkdchen deleted the STONEBLD-2661-update-buildah-image branch August 13, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants