-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally skip SBOM generation #1507
Conversation
8913530
to
b37c8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just need to wait for the Tekton change so that we can increase the size of buildah-remote. :) |
This cannot be merged until the version of Tekton is updated. I think that is planned on Monday with redhat-appstudio/infra-deployments#5201 |
Hello @arewm. FYI version 0.3 of |
Thanks for letting me know. I just pushed the changes. |
Since we can require SBOMs to be present with EC policies, we can enable users to optionally speed up their builds by not analyzing repositories to generate build-time SBOMs. While we may have a partial SBOM from the prefetched data, we should just not upload an SBOM at all in order to simplify decisions (i.e. removing the need to decide if the SBOM is full or partial). Signed-off-by: arewm <[email protected]>
Looks good to me. Do we have a procedure for deprecating older versions of the buildah task though? I'm fine with updating 0.2 too, just wondering. |
The 0.2 task can be deprecated whenever we determine that it is best to do it. Since it is not currently deprecated, I think it makes most sense to apply this change to both. |
Since we can require SBOMs to be present with EC policies, we can enable
users to optionally speed up their builds by not analyzing repositories
to generate build-time SBOMs.
While we may have a partial SBOM from the prefetched data, we should
just not upload an SBOM at all in order to simplify decisions (i.e.
removing the need to decide if the SBOM is full or partial).