Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX sbom support for oci-copy tasks [CLOUDDST-24635] #1509

Closed
wants to merge 6 commits into from

Conversation

midnightercz
Copy link

@midnightercz midnightercz commented Oct 15, 2024

@openshift-ci openshift-ci bot requested review from ralphbean and tkdchen October 15, 2024 09:59
@ralphbean
Copy link
Member

/ok-to-test

@ralphbean
Copy link
Member

At ralphbean/merlinite-poc#15, my attempt to test this failed with:

/tekton/scripts/script-2-dfzbf: line 3: unexpected EOF while looking for matching `)'
/tekton/scripts/script-2-dfzbf: line 83: syntax error: unexpected end of file

Signed-off-by: Jindrich Luza <[email protected]>
@midnightercz
Copy link
Author

now it should be fixed

@midnightercz
Copy link
Author

How do I check output of task-lint-check ?
It shows me:
Unable to load pipeline run build-definitions-pull-request-r2kf5
Invalid token. Are you working with Prod SSO token?

@zregvart
Copy link
Member

@midnightercz from https://github.com/konflux-ci/build-definitions/pull/1509/checks?check_run_id=32004059983:

Tasks contains params in script section (https://tekton.dev/docs/pipelines/tasks/#substituting-in-script-blocks)
task/oci-copy-oci-ta/0.1/oci-copy-oci-ta.yaml
task/oci-copy/0.1/oci-copy.yaml

Signed-off-by: Jindrich Luza <[email protected]>
@midnightercz
Copy link
Author

Previous build failed on:

task e2e-tests has the status "Failed":

42 Pending | 325 Skipped
--- FAIL: TestE2E (207.91s)
FAIL

Again, how do I get more details about the failure?

@ralphbean
Copy link
Member

I think this conflicts with #1687

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ralphbean
Copy link
Member

Yeah, next step. This needs to be rebased on top of main in light of #1687.

@kosciCZ
Copy link
Contributor

kosciCZ commented Jan 7, 2025

@midnightercz While this PR was open, I implemented a better name for the oci-copy task (#1687). Could you please replicate that for SPDX in this PR?

@chmeliik
Copy link
Contributor

FYI: the build team has taken over this work. Currently evaluating whether to continue with this approach or implement an oci-copy-sbom script in https://github.com/konflux-ci/build-tasks-dockerfiles

Most likely the latter, because #1509 (comment) would best be addressed by using the add_image_reference.py script from that repo.

@chmeliik
Copy link
Contributor

Closing in favor of #1816

@chmeliik chmeliik closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants