-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EC verify task timeout infinite #1613
base: main
Are you sure you want to change the base?
Conversation
/retest |
2 similar comments
/retest |
/retest |
|
Looking at the list of fields that accept variable substitutions, I don't think |
Well, what's our alternative. If we can't use variable substitution here, we can hardcode a super long timeout... |
we can set timeot 0 as unlimited and rely on pipeline timeout to kill it eventually |
Good idea @MartinBasti . Updated. |
Before this change, users could use the TIMEOUT param to increase their timeout up from the 5m default, but they would hit a ceiling. If they increased their timeout past 2h, then a tekton default on timeout for the task itself would kick in.
Also worth mentioning https://issues.redhat.com/browse/EC-1030. The CLI itself has a timeout. |
/retest |
|
Maybe original PR was good and we only need newer version of tekton
|
Before this change, users could use the TIMEOUT param to increase their timeout up from the 5m default, but they would hit a ceiling. If they increased their timeout past 2h, then a tekton default on timeout for the task itself would kick in.