RFC: task: prefetch: Condense the RHSM entitlement RPM repositories logic to a single step #1850
Conversation
This is a partial revert of commit 5f62fe3 which introduced the RH subscription manager handling logic in form of multiple steps. None of these steps were ever re-used as a step action. Moreover, we have faced several issues with RHSM unregister issues because the unregistering happened in a different context (because it was a separate step). This patch condenses the original logic from several steps into a single one - the main prefetch step - and rewrites everything in Bash to make the task consistent and unified (original used inline Python for a specific task which may have been arguably been more readable than 'jq' magic). Signed-off-by: Erik Skultety <[email protected]>
|
Worth noting that although early failure isn't currently enforced in Bash, the solution as proposed should still employ something like |
| @@ -325,6 +183,50 @@ spec: | |||
| script: | | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
Can we use this opt set -euo pipefail to make sure that we fail early, and then use trap to unregister? It's confusing to users to see script continues when there was a failures. It generates misleading output.
There was a problem hiding this comment.
I thought it was proposed in a different PR, but sure, I can enable it in a separate commit and as I mentioned in a different response to the PR add the trap.
| creds="$(cat /activation-key/org /activation-key/activationkey)" | ||
| IFS=$'\n' read -r RHSM_ORG RHSM_ACT_KEY <<<"$creds" |
There was a problem hiding this comment.
These 2 lines should not be here, that's some (clearly) failed rebase attempt, consider them deleted in favour of the 2 lines above them.
Depends on: containerbuildsystem/cachi2#792
Opening as an RFC draft since this solution currently relies on a custom-built cachi2 image which the task was tested with in a private Konflux deployment. Once the dependent PR is merged AND this solution is accepted I will lift the Draft status. Pasting a (publishable) snippet from the pipelines log: