Create buildah-proxy-oci-ta. #1853
Open
+996
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorhun
reviewed
Jan 23, 2025
| app.kubernetes.io/version: 0.2.1 | ||
| build.appstudio.redhat.com/build_type: docker | ||
| spec: | ||
| description: |- |
There was a problem hiding this comment.
There is nothing about the proxy or its purpose in the task description.
| apiVersion: tekton.dev/v1 | ||
| kind: Task | ||
| metadata: | ||
| name: buildah-proxy-oci-ta |
There was a problem hiding this comment.
Is it supposed to be just a buildah task with a generic proxy?
mmorhun
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware (PNC) needs a way to run builds with controlled network access. Instead of blocking all network access (hermetic build) this PR add a Domain Proxy and Indy Sidecar to the buildah-oci task.
The Domain proxy provides an option to get controlled network access from the unshare namespace. Domain proxy allows all network traffic but forces it to go through Indy proxy and Indy maven repository.
Indy sidecar is used to forward all network traffic to Indy http proxy, it's required because Indy http proxy running in OpenShift endpoint cannot be exposed as an OpenShift Route (Ingress) providing proxy functionality.
This PR is replacing the
generic proxy: #1815
domain proxy: #1822