Add script for generating SBOM from oci-copy.yaml #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
force-pushed
the
oci-copy-sbom-script
branch
from
b85b708 to
c21cdb4
Compare
chmeliik
force-pushed
the
oci-copy-sbom-script
branch
2 times, most recently
from
2f17818 to
5f30f1b
Compare
Needed for the oci-copy task [1] in build-definitions Note: unlike the oci-copy task script, this script doesn't put anything useful in the .metadata.component attribute. That's OK, because this script should be used in tandem with the add_image_reference script, which will set that attribute. [1]: https://github.com/konflux-ci/build-definitions/blob/main/task/oci-copy/0.1/oci-copy.yaml Signed-off-by: Adam Cmiel <[email protected]>
Note: the top-level attributes in the SPDX SBOM are mostly based on the index_image_sbom_script script Note 2: the SBOM's top-level name attribute and the fake_root package are mostly irrelevant, because this script should be used in tandem with the add_image_reference script, which will replace both. Signed-off-by: Adam Cmiel <[email protected]>
Signed-off-by: Adam Cmiel <[email protected]>
|
/retest |
|
Tested in konflux-ci/build-definitions#1816 => transitively in ralphbean/merlinite-poc#17 |
chmeliik
force-pushed
the
oci-copy-sbom-script
branch
from
5f30f1b to
fde7d1a
Compare
|
/retest |
Also fix a typo in the workflow yaml Signed-off-by: Adam Cmiel <[email protected]>
|
Forgot to run the unit tests for the new script in CI. Added in latest commit |
mmorhun
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a saner way to generate SBOMs from oci-copy.yaml compared to what the task is currently doing. Especially now that SPDX support is needed as well.