Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt konflux-demo for konflux-ci #1267

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

psturc
Copy link
Member

@psturc psturc commented Jul 18, 2024

Description

  • update konflux-demo test to be compatible with both downstream (infra-deployments) and upstream (konflux-ci/konflux-ci) versions of konflux

Issue ticket number and link

KONFLUX-3683

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested the code changes also in konflux-ci repo in this check run

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Jul 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@psturc psturc changed the title fix: adapt rhtap-demo for konflux-ci fix: adapt konflux-demo for konflux-ci Nov 1, 2024
@github-actions github-actions bot added 1-5 min and removed 5-10 min labels Nov 1, 2024
@psturc psturc force-pushed the KONFLUX-3683 branch 3 times, most recently from 6405e74 to fd3ca67 Compare December 12, 2024 11:14
@psturc
Copy link
Member Author

psturc commented Jan 20, 2025

/retest

@psturc
Copy link
Member Author

psturc commented Jan 22, 2025

/retest

@ascerra
Copy link
Contributor

ascerra commented Jan 23, 2025

Do we need to update the README here describing this new case for konflux demo-test
https://github.com/konflux-ci/e2e-tests/blob/9a6c4554c393b526a24c3b137a59faae436afc61/tests/konflux-demo/README.md?plain=1

Maybe here to show the run command for the upstream case?
https://github.com/konflux-ci/e2e-tests/blame/9a6c4554c393b526a24c3b137a59faae436afc61/tests/konflux-demo/README.md#L43

@github-actions github-actions bot added 5-10 min and removed 1-5 min labels Jan 24, 2025
@ascerra
Copy link
Contributor

ascerra commented Jan 24, 2025

/lgtm

Copy link

openshift-ci bot commented Jan 24, 2025

@ascerra: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ascerra
Copy link
Contributor

ascerra commented Jan 24, 2025

/lgtm

@psturc
Copy link
Member Author

psturc commented Jan 24, 2025

/approve

1 similar comment
@ascerra
Copy link
Contributor

ascerra commented Jan 24, 2025

/approve

Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ascerra, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 48eb3cd into konflux-ci:main Jan 24, 2025
13 checks passed
@psturc psturc deleted the KONFLUX-3683 branch January 24, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants