-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1102): remove unused data.fbc params #1412
base: main
Are you sure you want to change the base?
Conversation
@jinqi7 can you please LGTM this? The code is already in prod and the e2e is not merged yet. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinqi7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/retest |
this commit removes iibServiceConfigSecret and iibOverwriteFromIndexCredential as both are paremeters pinned by the FBC pipeline and should not be rewritten.
a4e7cfb
to
6c2c282
Compare
New changes are detected. LGTM label has been removed. |
/unhold |
this commit removes iibServiceConfigSecret and iibOverwriteFromIndexCredential as both are paremeters pinned by the FBC pipeline and should not be rewritten.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: