Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1102): remove unused data.fbc params #1412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theflockers
Copy link
Contributor

this commit removes iibServiceConfigSecret and iibOverwriteFromIndexCredential as both are paremeters pinned by the FBC pipeline and should not be rewritten.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from happybhati and mmalina October 1, 2024 08:54
@theflockers
Copy link
Contributor Author

@jinqi7 can you please LGTM this? The code is already in prod and the e2e is not merged yet.

@psturc
Copy link
Member

psturc commented Oct 11, 2024

/retest

@jinqi7
Copy link
Contributor

jinqi7 commented Oct 22, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinqi7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7
Copy link
Contributor

jinqi7 commented Oct 22, 2024

/hold
The CI checks passed long time ago. The PR need to be rebased.

@jinqi7
Copy link
Contributor

jinqi7 commented Oct 23, 2024

/retest

this commit removes iibServiceConfigSecret  and iibOverwriteFromIndexCredential
as both are paremeters pinned by the FBC pipeline and should not be rewritten.
Copy link

openshift-ci bot commented Oct 23, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added approved and removed lgtm labels Oct 23, 2024
@jinqi7
Copy link
Contributor

jinqi7 commented Oct 23, 2024

/unhold
/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants