feat(KONFLUX-2742) add a file upload function #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got a build of oras at https://github.com/ralphbean/oras which is what is referenced in the Dockerfile here. We shouldn't really merge that but should move that repo to github.com/konflux-ci and into some better workspace. Just PoC here. |
The intent is to use this in the snyk sast task to upload the sarif result to the registry for later post-processing by other systems. Signed-off-by: Ralph Bean <[email protected]>
MartinBasti
reviewed
Apr 22, 2024
| exit 2 | ||
| fi | ||
|
|
||
| if ! raw_inspect_output=$(skopeo inspect --no-tags docker://"${OCI_SUBJECT}"); then |
There was a problem hiding this comment.
I'd not call it raw because it's without skopeo --raw option
MartinBasti
reviewed
Apr 22, 2024
| echo "Failed to inspect ${OCI_SUBJECT}" >&2 | ||
| exit 2 | ||
| fi | ||
| if ! DIGEST=$(echo "${raw_inspect_output}" | jq -r .Digest | sed 's/:/-/'); then |
There was a problem hiding this comment.
Which digest do we care about here? I't think it's only manifest digest, what should be done in case of index image?
skopeo inspect --raw docker://"${OCI_SUBJECT}" | sha256sum will work for all cases
|
konflux-ci/build-definitions#992 and https://github.com/konflux-ci/oras-container/ replace this. I'm dropping this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to use this in the snyk sast task to upload the sarif result to the registry for later post-processing by other systems.