feat: RemoteDependencyTelemetry mutable timestamp
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality for specifying the timestamp of a `RemoteDependencyTelemetry`, instead of always using `Utc::now()`. This enables setting the timestamp of the request to e.g. when the dependency call was initiated, instead of when the telemetry item was submitted (which normally would be when the dependency processing was finished).
vegardgs-ksat
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality for specifying the timestamp of a
RemoteDependencyTelemetry, instead of always usingUtc::now().This enables setting the timestamp of the request to e.g. when the dependency call was initiated, instead of when the telemetry item was submitted (which normally would be when the dependency processing was finished).