[BUGFIX] Fix external redirects with custom pageNotFound handler #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix external redirects in multi-page, multi-domain setups with custom pageNotFound handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix external redirects in multi-page, multi-domain setups with custom pageNotFound handlers.
Previously, external redirects for the non-default domain would fail.
A configuration of the defaultRootPageId is not always an, as possible root pages may depend on the current domain. The TSFE would then be created for page uid 1 (last fallback).
Page uid 1 is typically unavailable for domains other than the default domain. Therefore the fake TSFE is unable to determine its page id and output 404.
Defaulting the page uid 0 will allow the TSFE to determine the page id by domain records.