fix: check version when checking if the model exists before registeri…

…ing it

.github/workflows/test.yaml → .github/workflows/test-release.yaml

@@ -49,7 +49,7 @@ jobs:
             changes: ${{ needs.check-folder-changes.outputs.go-sdk }}
           - component: py-sdk
             changes: ${{ needs.check-folder-changes.outputs.py-sdk }}
-          
+
     steps:
       - name: Checkout code
         if: matrix.changes == 'true'
@@ -138,3 +138,26 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.PAT }}  # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets[matrix.sonar_token_secret] }}
+
+  release:
+    name: Release
+    runs-on: ubuntu-latest
+    needs:
+      - unit-tests
+      - sonarcloud
+    if: github.ref_name == 'main'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Install nodejs
+        uses: actions/setup-node@v4
+        with:
+          node-version: "19"
+      - name: Run semantic release
+        run: |
+          npm install
+          npx multi-semantic-release
+        env:
+          GITHUB_TOKEN: ${{ secrets.PAT }}

go-sdk/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "go-sdk"
+}

package.json

@@ -0,0 +1,24 @@
+{
+  "name": "konstellation-runtimes",
+  "private": true,
+  "workspaces": [
+    "go-sdk/",
+    "py-sdk/"
+  ],
+  "release": {
+    "branches": [
+      "main"
+    ],
+    "plugins": [
+      "@semantic-release/commit-analyzer",
+      "@semantic-release/release-notes-generator",
+      "@semantic-release/github"
+    ]
+  },
+  "multi-release": {
+    "tagFormat": "${name}/v${version}"
+  },
+  "dependencies": {
+    "@qiwi/multi-semantic-release": "^7.1.1"
+  }
+}

py-sdk/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "py-sdk"
+}

py-sdk/sdk/sdk/model_registry/model_registry.py

@@ -118,8 +118,11 @@ def register_model(
         if not model:
             raise EmptyModelError()
 
-        exist = self._object_exist(name)
-        if exist:
+        try:
+            self.get_model(name, version)
+        except FailedToGetModelError:
+            pass
+        else:
             self.logger.error(f"model {name} already exists in model registry")
             raise ModelAlreadyExistsError(name, version)
 

py-sdk/sdk/sdk/model_registry/model_registry_test.py

@@ -170,8 +170,8 @@ def test_register_model_ko(_, m_model_registry):
     m_model_registry.minio_client.put_object.assert_called_once()
 
 
-@patch("sdk.model_registry.model_registry.ModelRegistry._object_exist", return_value=True)
-def test_register_model_already_exists_ko(_, m_model_registry):
+@patch("sdk.model_registry.model_registry.ModelRegistry.get_model", return_value=EXPECTED_MODEL)
+def test_register_model_already_exists_ko(_, m_model_registry, m_model):
     name = "test-key"
     model = io.BytesIO(b"test-payload")