Skip to content
This repository has been archived by the owner on Jan 21, 2025. It is now read-only.

Authentication persistent storage PY #92

Merged
merged 37 commits into from
Nov 16, 2023
Merged

Authentication persistent storage PY #92

merged 37 commits into from
Nov 16, 2023

Conversation

dfinteligenz
Copy link
Contributor

@dfinteligenz dfinteligenz commented Nov 6, 2023 •
edited by kafkaphoenix
Loading

  • Go Persistent storage changes:
    • Remove withVersions option to list method as we only return the latest, update logic in order to retrieve expiration date and version id (for this we need to use stat object as the response from the list method only returns the key)
  • Python Persistent Storage:
    • Rename related env variables and add new ones for authentication step
    • New authentication module implementing keycloack authentication but more can be added in the future
    • Get returns a new dataclass object called object with the fields: data, key, version id, expiration, user metadata
    • List and List versions return a new dataclass object called object info with the fields key, version id, expiration and metadata
    • Post init uses the new auth step
    • Change save method expiration logic to use rules and bucket lifecycle (Previous logic was wrong)
    • Add metadata and extra information to all methods
    • Two new private methods to extract metadata and expiration date

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other changes (ci configuration, documentation or any other kind of changes)

Checklist:

  • I have created tests for my code changes, and the tests are passing.
  • I have executed the pre-commit hooks locally.
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).
  • I have updated the documentation accordingly.

dovixman and others added 13 commits October 30, 2023 08:49
feat: add persistent storage methods to the Go SDK
0591023
@dfinteligenz
Merge branch 'develop' into feature/persistent-storage
b6ca833
fix: update demo processes app.yaml config
2b191fa
@kafkaphoenix @dfinteligenz
feat: add persistant storage methods to Python SDK (#73)
b366f7c 
Co-authored-by: David Fuentes <[email protected]>
@kafkaphoenix
fix: persistent storage save method missing version id return
fce961f
@kafkaphoenix
feat: test remaining capabilities persistent storage
a2fcf3a
feat: add persistent storage methods to the Go SDK
94e206e
Merge remote-tracking branch 'origin/develop' into feature/persistent…
3d59238 
…-storage
feat: add persistent storage methods to the Go SDK
0da4a84
Merge remote-tracking branch 'origin/develop' into feature/persistent…
004e0b1 
…-storage
deps: add updated go sum
2c95d7a
feat: add IdP authentication to the persistent storage
b4c9373
feat: add IdP authentication to the persistent storage
020111e
@dfinteligenz dfinteligenz self-assigned this Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@dfinteligenz dfinteligenz marked this pull request as ready for review November 7, 2023 18:27
@dfinteligenz dfinteligenz marked this pull request as draft November 7, 2023 18:27
@github-actions github-actions bot added size/l and removed size/xl labels Nov 7, 2023
@kafkaphoenix kafkaphoenix force-pushed the feature/authentication-persistent-storage-py branch from 48805d4 to 37174b6 Compare November 14, 2023 11:16
@github-actions github-actions bot added size/xl and removed size/l labels Nov 14, 2023
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarqubecloud SonarQubeCloud
Copy link

[AIO - GO SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

[KAI - Python SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
22.2% 22.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dfinteligenz dfinteligenz merged commit 23801ad into develop Nov 16, 2023
8 of 9 checks passed
@dfinteligenz dfinteligenz deleted the feature/authentication-persistent-storage-py branch November 16, 2023 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kafkaphoenix kafkaphoenix kafkaphoenix approved these changes

@JYisus JYisus Awaiting requested review from JYisus

@alexrodfe alexrodfe Awaiting requested review from alexrodfe

Assignees

@dfinteligenz dfinteligenz

Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfinteligenz @kafkaphoenix