Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): [KDL6-228] minio keycloak client #1120

Merged

Conversation

igzor
Copy link
Collaborator

@igzor igzor commented Jan 14, 2025

Motivation and Context

This PR registers the MinIO console as a OIDC client in Keycloak.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have created tests for my code changes, and the tests are passing.
  • [X ] I have executed the pre-commit hooks locally.
  • I have updated the documentation accordingly.
  • [X ] The commit message follows our guidelines: https://github.com/konstellation-io/kdl-server/blob/main/CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).

PR Type

  • Bugfix
  • [X ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

No OIDC support for Minio console

Closes #KDL6-228

What is the new behavior?

Keycloak now accepts OIDC request from MinIO

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

Other information

@igzor igzor requested review from pablon and removed request for kafkaphoenix and alexrodfe January 14, 2025 16:10
@igzor igzor changed the title Feat(config):[KDL6-228] minio keycloak client feat(config): [KDL6-228] minio keycloak client Jan 14, 2025
Copy link

Quality Gate Failed Quality Gate failed for 'kdl-server-app-api'

Failed conditions
67.6% Coverage on New Code (required ≥ 80%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@igzor igzor changed the base branch from main to feat/KDL6-46-data-privacy January 15, 2025 08:35
@igzor igzor merged commit 1123878 into feat/KDL6-46-data-privacy Jan 15, 2025
9 of 14 checks passed
@igzor igzor deleted the feat/KDL6-228-minio-keycloak-client branch January 15, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants