Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): [KDL6-290] fixing minio project creation #1141

Merged

Conversation

igzor
Copy link
Collaborator

@igzor igzor commented Jan 28, 2025

Motivation and Context

It has been found (by @javier Gil ) that the order of MinIO Project Policy creation and MinIO Project User creation is reversed.

PR Checklist

  • I have created tests for my code changes, and the tests are passing.
  • I have executed the pre-commit hooks locally.
  • I have updated the documentation accordingly.
  • The commit message follows our guidelines: https://github.com/konstellation-io/kdl-server/blob/main/CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

infrastructure/minio-admin tests correct behavior creating policy before user
usecase/project applies the inverse order.

What is the new behavior?

usecase/project to follow the same order: creating policy before user

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@igzor igzor changed the base branch from main to feat/KDL6-46-data-privacy January 28, 2025 16:15
Copy link

@igzor igzor changed the title feat(API): [KDL6-290] fixing minio project creation fix(API): [KDL6-290] fixing minio project creation Jan 29, 2025
@igzor igzor force-pushed the feat/KDL6-290-fixing-minio-project-creation branch from c2387c6 to b33b53a Compare January 29, 2025 10:44
@igzor igzor merged commit 056de59 into feat/KDL6-46-data-privacy Jan 29, 2025
2 checks passed
@igzor igzor deleted the feat/KDL6-290-fixing-minio-project-creation branch January 29, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants