Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let users install applications from the GitOps catalog that won't work on k3d #36

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

tomekz
Copy link
Contributor

@tomekz tomekz commented Oct 17, 2023

Linked issue

  • added k3d field to index.yaml
    • if false the application can't be installed on a k3d cluster.
    • If omitted, we assume it can be installed

@fharper
Copy link
Contributor

fharper commented Oct 23, 2023

Sorry @tomekz, I was out last week, and the team was focussing on the v2.3 release for this week, so they missed your PR.

I'll review it today.

@tomekz
Copy link
Contributor Author

tomekz commented Oct 23, 2023

Thanks @fharper
I've signed off all the commits also as I see it is required
I did open one side quest tiny PR for console, not related to the issue. Pls have a look

@fharper
Copy link
Contributor

fharper commented Oct 23, 2023

@tomekz can you sign your commit please? In the meantime, I'll review the PRs for this.

I read somewhere you did, but maybe you didn't push your change as they are not signed. If you're successful, you'll see the verified badge next to them, like this.

CleanShot 2023-10-23 at 15 41 14@2x

@fharper
Copy link
Contributor

fharper commented Oct 23, 2023

@fharper fharper merged commit 1f5fa11 into konstructio:main Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants