Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable ufw_incoming_traffic #801

Closed
wants to merge 2 commits into from

Conversation

jdaln
Copy link
Contributor

@jdaln jdaln commented Dec 5, 2024

Hello @konstruktoid !

I would like to add this ufw_incoming_traffic variable allows users to specify which incoming ports should be opened in UFW.

I have tried to add a few tests but I was not able to get the testing environment setup on my machine. May I request you to test this please? I am quite time-constraint lately and won't have time to debug the installation.

@jdaln jdaln requested a review from konstruktoid as a code owner December 5, 2024 18:58
@konstruktoid
Copy link
Owner

Thanks for the PR, but I believe that additional ports should be configured in the service roles, eg add port 80/443 openings in your webserver role.

Regarding ssh it's configured at https://github.com/konstruktoid/ansible-role-hardening/blob/master/tasks/ufw.yml#L121-L128 and mentioned in the readme at https://github.com/konstruktoid/ansible-role-hardening/blob/master/README.md?plain=1#L116-L118

@jdaln
Copy link
Contributor Author

jdaln commented Dec 9, 2024

Alright, then this is outside the scope of this playbook. Also, true that ssh was already configured, my bad.

Closing the PR.

@jdaln jdaln closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants