Бочаров Александр #185
Open
Бочаров Александр #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masssha1308
reviewed
Jan 7, 2025
| ? ReadFromExistingFile(path) | ||
| : Result.Fail<List<string>>("No file found"); | ||
|
|
||
| public abstract Result<List<string>> ReadFromExistingFile(string path); |
masssha1308
reviewed
Jan 7, 2025
|
|
||
| namespace TagCloud.WordsReader.Readers; | ||
|
|
||
| public abstract class BaseFileReader(string path) : IWordsReader |
There was a problem hiding this comment.
Нет необходимости в двух абстракциях (и интерфейс, и абстрактный класс)
masssha1308
reviewed
Jan 7, 2025
| @@ -18,7 +19,7 @@ public CsvFileReader(CsvFileReaderSettings settings) | |||
| : this(settings.FilePath, settings.Culture) | |||
masssha1308
reviewed
Jan 7, 2025
| public Result<List<string>> ReadWords() | ||
| => File.Exists(path) | ||
| ? ReadFromExistingFile(path) | ||
| : Result.Fail<List<string>>("No file found"); |
There was a problem hiding this comment.
В ридерах обрабатывается только 1 одна ошибка (не найден файл), но явно могут возникнуть и другие. Давай их тоже обработаем
masssha1308
reviewed
Jan 7, 2025
| @@ -10,8 +11,8 @@ public class CircularCloudLayouter(Point layoutCenter, IPointsGenerator pointsGe | |||
| private const string FiniteGeneratorExceptionMessage = | |||
There was a problem hiding this comment.
А почему текст решил вынести в константу? Смущает что текст ошибки только в одном месте константа, во всех остальных нет, хочется придерживаться одного подхода во всей задаче
masssha1308
reviewed
Jan 7, 2025
| "./Dictionaries/enUS.aff"); | ||
| private const string EnglishDic = "./Dictionaries/enUS.dic"; | ||
| private const string EnglishAff = "./Dictionaries/enUS.aff"; | ||
| public Result<List<string>> ApplyFilter(List<string> words) |
There was a problem hiding this comment.
А почему не IEnumerable? Если сделать IEnumerable, то можно не делать приведения к List как в строке 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.