Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] added focus method for new custom migration target #702

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[RFR] added focus method for new custom migration target #702

merged 2 commits into from
Sep 4, 2023

Conversation

Neilhamza
Copy link
Collaborator

@Neilhamza Neilhamza commented Aug 30, 2023 •
edited
Loading

@Neilhamza Neilhamza requested review from ibragins and abrugaro August 30, 2023 08:00
@abrugaro abrugaro self-requested a review August 30, 2023 08:16
abrugaro
abrugaro requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests failed, please see if its fixable or mark the bug number in the test name

image

@Neilhamza
using clickJs method
46c454f 
Signed-off-by: Neilhamza <[email protected]>
abrugaro
abrugaro approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

nachandr
nachandr approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@nachandr nachandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrugaro abrugaro merged commit fd9a300 into konveyor:main Sep 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibragins ibragins ibragins requested changes

@abrugaro abrugaro abrugaro approved these changes

@nachandr nachandr nachandr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neilhamza @nachandr @ibragins @abrugaro