Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Initial commit for issues functionality #736

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

ibragins
Copy link
Collaborator

@ibragins ibragins commented Oct 4, 2023

No description provided.

cypress/utils/utils.ts Outdated Show resolved Hide resolved
@@ -37,7 +37,7 @@ export const descriptionHelper = "div[id=description-helper]";
export const emailHelper = "div[id=email-helper]";
export const filterToggleButton = "div.pf-c-dropdown > button.pf-c-dropdown__toggle";
export const filterInput = "input[type='search']";
export const searchButton = "button[aria-label='search button for search input']";
export const searchButton = "#search-button";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ibragins ibragins changed the title [WIP] Initial commit for issues functionality [RFR] Initial commit for issues functionality Oct 12, 2023
Signed-off-by: Igor Braginsky <[email protected]>
Signed-off-by: Igor Braginsky <[email protected]>
Signed-off-by: Igor Braginsky <[email protected]>
Signed-off-by: Igor Braginsky <[email protected]>
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, nice changes!

cypress/e2e/models/migration/dynamicreports/issue.ts Outdated Show resolved Hide resolved
if (selectorMap[item]) {
inputText(selectorMap[item], itemName);
click(searchButton);
} else if (item == filterIssue.bs && !Array.isArray(itemName)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make dynamic Id's but okay for this PR.

@sshveta sshveta merged commit 2f9d7b4 into konveyor:main Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants