-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update stakeholder groups table to use ActionsColumn #2095
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 39.20% 42.01% +2.81%
==========================================
Files 146 175 +29
Lines 4857 5617 +760
Branches 1164 1340 +176
==========================================
+ Hits 1904 2360 +456
- Misses 2939 3241 +302
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4916829
to
9502897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MiriSafra for the PR. Please see my comments
client/src/app/pages/controls/stakeholder-groups/stakeholder-groups.tsx
Outdated
Show resolved
Hide resolved
a58d8fa
to
9322808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: MiriSafra <[email protected]>
0b93e88
to
9b17c3a
Compare
Closed and reopened the PR to update the description with UI tests PR for CI check |
@MiriSafra PR looks good - I've changed the title so that it would look more like previous work on this topic - see #1923 |
Addition ActionsColumn to Stakeholder groups table Relates to konveyor#1318 UI tests PR: 1222 Signed-off-by: MiriSafra <[email protected]>
Addition ActionsColumn to Stakeholder groups table
Relates to #1318
UI tests PR: 1222