🐛 notifications close all together bug #2118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalyaNaima
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
TalyaNaima
force-pushed
the
Talya-Notification-close-all-together-bug
branch
from
01b7f08 to
dd06378
Compare
Signed-off-by: TalyaNaima <[email protected]>
Signed-off-by: TalyaNeima <[email protected]> Signed-off-by: TalyaNaima <[email protected]>
Signed-off-by: TalyaNaima <[email protected]> Signed-off-by: TalyaNaima <[email protected]>
TalyaNaima
force-pushed
the
Talya-Notification-close-all-together-bug
branch
from
dd06378 to
a771b1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5629 +772
Branches 1164 1341 +177
==========================================
+ Hits 1904 2363 +459
- Misses 2939 3250 +311
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TalyaNaima
force-pushed
the
Talya-Notification-close-all-together-bug
branch
2 times, most recently
from
c88e295 to
7a473d6
Compare
Signed-off-by: TalyaNaima <[email protected]>
TalyaNaima
force-pushed
the
Talya-Notification-close-all-together-bug
branch
from
7a473d6 to
6658065
Compare
|
@TalyaNaima -- Do you intend to move this PR out of draft? |
rszwajko
reviewed
Nov 19, 2024
| @@ -507,7 +507,8 @@ | |||
| "success": { | |||
| "saveWhat": "{{type}} {{what}} was successfully saved.", | |||
| "save": "{{type}} was successfully saved.", | |||
| "applicationDeleted": "{{appIDCount}} application(s) successfully deleted.", | |||
| "applicationDeleted": "{{appName}} application(s) successfully deleted.", | |||
There was a problem hiding this comment.
I'm not a native speaker but I would suggest Application {{appName}} successfully deleted.
| @@ -345,6 +353,7 @@ export const ApplicationsTable: React.FC = () => { | |||
| businessService: app.businessService?.name || "", | |||
| tags: app.tags?.length || 0, | |||
| effort: app.effort || 0, | |||
| analysis: app.tasks.currentAnalyzer?.state || 0, | |||
There was a problem hiding this comment.
Is this change related to the fix? If no then please revert.
| @@ -7,7 +7,7 @@ export interface ApplicationAnalysisStatusProps { | |||
| state: TaskState; | |||
| } | |||
|
|
|||
| const taskStateToAnalyze: Map<TaskState, IconedStatusPreset> = new Map([ | |||
| export const taskStateToAnalyze: Map<TaskState, IconedStatusPreset> = new Map([ | |||
There was a problem hiding this comment.
Is this change related to the fix?
TalyaNaima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing MTE-3095 bug by making the delete notifications distinguishable