Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings #87

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Use f-strings #87

merged 1 commit into from
Jan 20, 2021

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Nov 25, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #87 (80887f4) into master (f81554d) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files           7        7           
  Lines        1284     1284           
  Branches      115      115           
=======================================
  Hits         1221     1221           
  Misses         43       43           
  Partials       20       20           
Impacted Files Coverage Δ
tnefparse/mapi.py 80.98% <0.00%> (ø)
tnefparse/tnef.py 92.83% <33.33%> (ø)
tnefparse/codepage.py 80.95% <50.00%> (ø)
tnefparse/cmdline.py 96.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81554d...80887f4. Read the comment docs.

@jugmac00
Copy link
Collaborator

Thanks for your contribution!

We had a short discussion about the usage of f-strings in #79 (comment) and as @petri merged the PR (with added f-strings), I think there is a consensus now to go with f-strings :-)

Quite some lines you changed are currently without coverage.

It would be awesome to add the missing coverage with this PR.

And also, as @petri suggested in another issue, please add a change log entry.

@jrideout jrideout merged commit 884f129 into koodaamo:master Jan 20, 2021
@eumiro eumiro deleted the f-strings branch January 20, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants