feat: set labelingInfo via metadata (#1015)

* feat: set labelingInfo via metadata

* chore: increase test coverage

.changeset/violet-fans-develop.md

@@ -0,0 +1,5 @@
+---
+"@koopjs/featureserver": minor
+---
+
+- set labelingInfo via metadata

packages/featureserver/package.json

@@ -23,7 +23,7 @@
     "@esri/proj-codes": "^3.3.0",
     "@koopjs/logger": "5.0.0",
     "@koopjs/winnow": "5.0.2",
-    "@terraformer/spatial": "^2.2.1",
+    "@turf/envelope": "^6.5.0",
     "chroma-js": "^2.4.2",
     "esri-extent": "^1.1.3",
     "geojson-validation": "^1.0.2",

packages/featureserver/src/helpers/feature-layer-metadata.js

@@ -1,7 +1,7 @@
 const _ = require('lodash');
 const TableLayerMetadata = require('./table-layer-metadata');
 const { PointRenderer, LineRenderer, PolygonRenderer } = require('./renderers');
-const { calculateBounds } = require('@terraformer/spatial');
+const envelope = require('@turf/envelope');
 const logManager = require('../log-manager');
 const getSpatialReference = require('./get-spatial-reference');
 const getGeometryTypeFromGeojson = require('./get-geometry-type-from-geojson');
@@ -22,47 +22,59 @@ class FeatureLayerMetadata extends TableLayerMetadata {
     return this;
   }
 
-  mixinOverrides(geojson = {}, options = {}) {
+  mixinOverrides(geojson, options = {}) {
     super.mixinOverrides(geojson, options);
 
-    const { renderer, extent, inputCrs, sourceSR, capabilities = {} } = options;
+    const { renderer, labelingInfo, extent, inputCrs, sourceSR, capabilities = {} } = options;
 
     this.geometryType = getGeometryTypeFromGeojson({ ...geojson, ...options });
 
     this.supportsCoordinatesQuantization = !!capabilities.quantization;
 
-    this._setExtent(geojson, { inputCrs, sourceSR, extent });
+    this.#_setExtent(geojson, { inputCrs, sourceSR, extent });
 
-    this._setRenderer(renderer);
+    this.#_setRenderer(renderer);
 
-    this._setDirectOverrides(options);
+    this.#_setLabelingInfo(labelingInfo);
+
+    this.#_setDirectOverrides(options);
 
     return this;
   }
 
-  _setExtent(geojson, options) {
+  #_setExtent(geojson, options) {
     const extent = getLayerExtent(geojson, options);
     if (extent) {
       this.extent = extent;
     }
   }
 
-  _setRenderer(renderer) {
+  #_setRenderer(renderer) {
     if (renderer) {
       this.drawingInfo.renderer = renderer;
       return;
     }
 
     if (this.geometryType === 'esriGeometryPolygon') {
       this.drawingInfo.renderer = new PolygonRenderer();
-    } else if (this.geometryType === 'esriGeometryPolyline') {
+      return;
+    }
+
+    if (this.geometryType === 'esriGeometryPolyline') {
       this.drawingInfo.renderer = new LineRenderer();
-    } else {
-      this.drawingInfo.renderer = new PointRenderer();
+      return;
     }
+
+    this.drawingInfo.renderer = new PointRenderer();
   }
 
-  _setDirectOverrides(options) {
+  #_setLabelingInfo(labelingInfo) {
+    if (labelingInfo) {
+      this.drawingInfo.labelingInfo = labelingInfo;
+    }
+  }
+
+  #_setDirectOverrides(options) {
     super._setDirectOverrides(options);
     const { minScale, maxScale } = options;
 
@@ -74,10 +86,7 @@ class FeatureLayerMetadata extends TableLayerMetadata {
 }
 
 function getLayerExtent(geojson, options) {
-  const spatialReference = getSpatialReference(geojson, options) || {
-    wkid: 4326,
-    latestWkid: 4326,
-  };
+  const spatialReference = getSpatialReference(geojson, options);
 
   const { extent } = options;
 
@@ -94,8 +103,15 @@ function calculateExtentFromFeatures(geojson, spatialReference) {
   }
 
   try {
-    const [xmin, ymin, xmax, ymax] = calculateBounds(geojson);
+    const { bbox } = envelope(geojson);
+
+    bbox.forEach((coordinate) => {
+      if (!isFinite(coordinate)) {
+        throw new Error(`Feature does not contain valid geometry`);
+      }
+    });
 
+    const [xmin, ymin, xmax, ymax] = bbox;
     return {
       xmin,
       xmax,