Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: classifier break count must >= features.length - 1 #1022

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

rgwozdz
Copy link
Member

@rgwozdz rgwozdz commented May 29, 2024

Fix for #1019.

@rgwozdz rgwozdz added winnow patch Increment the patch version when merged release Create a release when this pr is merged labels May 29, 2024
@rgwozdz rgwozdz self-assigned this May 29, 2024
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: c7f72c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@koopjs/winnow Patch
@koopjs/featureserver Patch
@koopjs/output-geoservices Patch
@koopjs/koop-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Coverage Report (change vs master)

File Path Statements Branches Functions Lines
packages/winnow/src/calculate-class-breaks/index.js 100.0 green
vs
90.3 yellowGreen
100.0 green
vs
80.0 orange
100.0 green
vs
100.0 green
100.0 green
vs
92.8 yellowGreen

@rgwozdz rgwozdz merged commit cc30f71 into master May 29, 2024
7 checks passed
@rgwozdz rgwozdz deleted the p/classify branch May 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged winnow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant