Fixed default Model cache key generation issue #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods ie. GET & POST The default generator was ignoring variances between GET & POST methods. This caused POST requests to get cached incorrectly.
🦋 Changeset detectedLatest commit: bece09a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failures are an issue with CI configuration, not PR changes. Tested locally, passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support GET & POST requests
The default generator was ignoring variances between
GET&POSTmethods. This causedPOSTrequests to get cached incorrectly. Now, both the request query and body are loaded and merged into a common object and stringified as part of the key generation omitting query params from the url string. This will make the url be the same betweenGETandPOSTand allow for the parameters to be common when submitted into the hasher function.Larger Hash Keys
I also updated the hasher method to use the larger hash size to help prevent collisions since large datasets can be submitted in as part of the caching data. Users of the api can submit in large sets of
OBJECTIDSand Geometry as part of query parameters. This should help mitigate any cache collisions.New Unit Tests
I added some new unit tests to verify that common
GETandPOSTrequests use the same cache even though the request urls will be different. (ie.GETwill be in the query string andPOSTwill be in the body)