Use Laravel Collection for Dialog Memory #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Idea: we don't need to create a custom API to manage items in Dialog::$memory, Collection implementations (e.g. Laravel Collection) already provide a way for this. We just need to make sure that existing serialised dialogs work with this new implementation.
New code example:
Old code example:
Because of these changes, we don't need
Dialog::remember
andDialog::forget
methods anymore. I market them as deprecated and they will be removed in the v1.0