Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(ui): Polish the UI #245

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

style(ui): Polish the UI #245

wants to merge 21 commits into from

Conversation

jasoryeh
Copy link

@jasoryeh jasoryeh commented Mar 29, 2024

Hello,

I discovered Kopia a bit ago, but the one thing that made this tool a bit intimidating was the user interface.

Here are a few stylistic changes to polish up some interfaces, still working on adding some other adjustments here and there to make the UI more friendly.

Among these changes:

  • Spacings between things like form items and elements to make everything less "squished" together
  • Fix dark mode inconsistencies (snapshot table)
  • De-clutter the policy editor to not be one giant accordion
  • Add some text to make the purpose of each page clearer
  • Moving the connected repository name to the navbar, and putting it at the top right
  • and more

Please let me know if there are any changes (to this PR or new changes) on your mind!

@lupusA
Copy link
Collaborator

lupusA commented Mar 30, 2024

Hey @jasoryeh ,
thanks for helping with the ui. I am currently working on the localisation and added also some improvements here and there.

Let's get the ui more consistent for the next release.

The changes so far are looking good 😊

@lupusA
Copy link
Collaborator

lupusA commented Mar 30, 2024

Regarding the next changes:

  1. We need to refactor the whole UI and use functions instead of components. It is basically a preparation to update the libraries (router etc.)
  2. Notifications would be a great new feature. The notifications should inform the user about important things such as completed snapshots etc.
  3. We need to work on the tests to increase the coverage.

@jkowalski
Copy link
Contributor

@jasoryeh thanks for your contributions,

please coordinate merging this change with @lupusA. I think we need to his localization merged first and update this PR as there will likely be a non-trivial conflict.

@jasoryeh
Copy link
Author

jasoryeh commented Apr 1, 2024

@lupusA I'll await your PR's merge and completion first, in the meantime, I've made a test branch (with rebase) including your changes and there are indeed many non-trivial conflicts.

https://github.com/jasoryeh/kopia-htmlui/tree/lupusA-language

I'll update that branch I tested as you make progress, then update this PR after your PR is completed.

@lupusA
Copy link
Collaborator

lupusA commented Apr 2, 2024

Hi @jasoryeh,

i will merge this weekend. There are some minor things which need to be fixed. However, this can be done after incorporating your changes.

Cheers,

@jasoryeh
Copy link
Author

@lupusA Any updates on #241, I've been looking to add more changes but don't want to introduce too many conflicts to manually go through later

@lupusA
Copy link
Collaborator

lupusA commented Jun 22, 2024

Hi @jasoryeh

#241 is currently on hold as I have other things to do. If you want, we can merge first and then I have to resolve the conflicts later on. What do you think?

Cheers,

jasoryeh added 20 commits June 26, 2024 20:34
…a at the top, and detailed data at the bottom
@jasoryeh
Copy link
Author

Hi @jasoryeh

#241 is currently on hold as I have other things to do. If you want, we can merge first and then I have to resolve the conflicts later on. What do you think?

Cheers,

Hi @lupusA osunds good, I'll convert this PR into a non-draft request, I'll save other improvements for another PR since this was just some small nit-picky things I wanted to fix!

@jasoryeh jasoryeh marked this pull request as ready for review June 27, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants