Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework DeviceInfo.kt #526

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Commits on Nov 10, 2024

  1. rework DeviceInfo.kt

    Reduce duplication to make it easier to maintain.
    
    Fix the following issues:
    
    - possible problem with `EINK` value on `TOLINO_EPOS3` devices
      (since both `TOLINO` and `TOLINO_EPOS3` booleans would be set)
    - `EINK` was never set to `EinkDevice.TOLINO_VISION6`,
      but checked in `device/EPDFactory.kt`
    - same with `HANVON_960` & `HYREAD_MINI6`
    - `LIGHTS` was never set to `LightsDevice.ONYX_NOTE_PRO`,
      but checked in `device/LightsFactory.kt`
    - `LIGHTS` could be set to `LightsDevice.ONYX_PALMA`,
      but was never checked in `device/LightsFactory.kt`
    
    Note: also drop device properties: `is_boyue` (unused) & `is_tolino`
    (only used to add direction pad mappings, details were added to the
    relevant wiki page instead), and no hardware rotation quirk (which
    was an incomplete emulator only workaround).
    benoit-pierre committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    f8c12ad View commit details
    Browse the repository at this point in the history