Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement kornia-dnn with RTDETR detector #129

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
resolver = "2"
members = [
"crates/kornia-core",
"crates/kornia-dnn",
"crates/kornia-image",
"crates/kornia-io",
"crates/kornia-imgproc",
Expand All @@ -26,6 +27,7 @@ version = "0.1.6+dev"

[workspace.dependencies]
kornia-core = { path = "crates/kornia-core", version = "0.1.6+dev" }
kornia-dnn = { path = "crates/kornia-dnn", version = "0.1.6+dev" }
kornia-image = { path = "crates/kornia-image", version = "0.1.6+dev" }
kornia-io = { path = "crates/kornia-io", version = "0.1.6+dev" }
kornia-imgproc = { path = "crates/kornia-imgproc", version = "0.1.6+dev" }
Expand Down
22 changes: 22 additions & 0 deletions crates/kornia-dnn/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[package]
name = "kornia-dnn"
authors.workspace = true
categories.workspace = true
description.workspace = true
edition.workspace = true
homepage.workspace = true
include.workspace = true
license.workspace = true
license-file.workspace = true
readme.workspace = true
repository.workspace = true
rust-version.workspace = true
version.workspace = true

[dependencies]
kornia-core = { workspace = true }
kornia-image = { workspace = true }
ort = { version = "2.0.0-rc.4", features = [
"load-dynamic",
edgarriba marked this conversation as resolved.
Show resolved Hide resolved
], default-features = false }
thiserror = "1"
11 changes: 11 additions & 0 deletions crates/kornia-dnn/src/error.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#[derive(thiserror::Error, Debug)]
pub enum DnnError {
#[error("Failed to load model")]
OrtError(#[from] ort::Error),

#[error("Image error")]
ImageError(#[from] kornia_image::ImageError),

#[error("Tensor error")]
TensorError(#[from] kornia_core::TensorError),
}
27 changes: 27 additions & 0 deletions crates/kornia-dnn/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
//! # Kornia DNN
//!
//! This module contains DNN (Deep Neural Network) related functionality.

/// Error type for the dnn module.
pub mod error;

/// This module contains the RT-DETR model.
pub mod rtdetr;

// TODO: put this in to some sort of structs pool module
/// Represents a detected object in an image.
#[derive(Debug)]
pub struct Detection {
/// The class label of the detected object.
pub label: u32,
/// The confidence score of the detection (typically between 0 and 1).
pub score: f32,
/// The x-coordinate of the top-left corner of the bounding box.
pub x: f32,
/// The y-coordinate of the top-left corner of the bounding box.
pub y: f32,
/// The width of the bounding box.
pub w: f32,
/// The height of the bounding box.
pub h: f32,
}
174 changes: 174 additions & 0 deletions crates/kornia-dnn/src/rtdetr.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
//! # RT-DETR
//!
//! This module contains the RT-DETR model.
//!
//! The RT-DETR model is a state-of-the-art object detection model.

use std::path::PathBuf;

use crate::error::DnnError;
use crate::Detection;
use kornia_core::{CpuAllocator, Tensor};
use kornia_image::Image;
use ort::{GraphOptimizationLevel, Session};

/// Builder for the RT-DETR detector.
///
/// This struct provides a convenient way to configure and create an `RTDETRDetector` instance.
pub struct RTDETRDetectorBuilder {
/// Path to the RT-DETR model file.
pub model_path: PathBuf,
/// Path to the ONNX Runtime dynamic library.
pub ort_dylib_path: PathBuf,
edgarriba marked this conversation as resolved.
Show resolved Hide resolved
/// Number of threads to use for inference.
pub num_threads: usize,
Copy link

@decahedron1 decahedron1 Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution providers can be registered through the environment so this is super minor but WDYT about an execution_providers: Vec<ExecutionProviderDispatch> field & with_execution_providers to configure EPs specifically for the RTDETR session?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to somehow make ort transparent to the user and avoid them to explicitly pass the ort::ExecutionProvider and have something custom

enum ExecutionProvided {
    Cpu,
    Cuda,
    TensorRT,
}

let execution_providers = match execution_provider {
    ExecutionProvider::Cpu => vec![CpuExecutionProvider::default()],
    ExecutionProvider::Cuda => vec![CUDAExecutionProvider::default()],
    ExecutionProvider::TensorRT => vec![TensorRTExecutionProvider::default()],
};

let session = Session::builder()?
     .with_optimization_level(GraphOptimizationLevel::Level3)?
     .with_intra_threads(num_threads)?
     .with_execution_providers([execution_providers])?
     .commit_from_file(model_path)?;

I'm still experimenting with the execution providers. What is the point of defining multiple as a Vec, just because of a fallback provider ?

I've played a bit with it and i noticed that cuda/tensorrt takes few seconds to run the first frames.

A couple of questions:

  • Is there any way to leave this to the constructor of the session before i fetch the session ? (might suffer some queuying issues with cameras)
  • For tensorrt, means that's is compiling the model at runtime ? could we somehow passe a compiled model ?
  • As for the commit_from_file -- the idea is that we will have a bunch of operators/models in our Kornia HF hub which can use the commit_from_url but somehow also let the user also to give a local onnx file. Any tips here ?

Copy link

@decahedron1 decahedron1 Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about re-exporting EPs like pub use ort::{CPUExecutionProvider, CUDAExecutionProvider, TensorRTExecutionProvider} so users can still configure each EP's options instead of being limited to defaults? That should still keep things neat.

What is the point of defining multiple as a Vec, just because of a fallback provider ?

Yes.

Is there any way to leave this to the constructor of the session before i fetch the session ? (might suffer some queuying issues with cameras)

You could run it on 1 dummy frame inside the constructor, that should get the graph warmed up.

For tensorrt, means that's is compiling the model at runtime ? could we somehow passe a compiled model ?

Yes, and for CUDA it is determining the most optimal cuDNN convolution kernels. By default it performs an exhaustive search which gets the best performance at the cost of significant warmup time - this can be configured with CUDAExecutionProvider::with_conv_algorithm_search.

TensorRT graphs can theoretically be cached with TensorRTExecutionProvider::with_engine_cache but some users in the pyke Discord have reported that ONNX Runtime sometimes doesn't respect this option, and session creation can still take a few seconds despite using a cached engine. Your mileage may vary, though; I personally haven't been able to reproduce the issue, but it's just something to keep in mind.

As for the commit_from_file -- the idea is that we will have a bunch of operators/models in our Kornia HF hub which can use the commit_from_url but somehow also let the user also to give a local onnx file. Any tips here ?

How about something like this? (very roughly)

pub trait ModelSource {
    fn commit_session(&self, builder: SessionBuilder) -> ort::Result<Session>;
}

pub trait SessionBuilderExt {
    fn commit_from_source<S: ModelSource>(self, source: S) -> ort::Result<Session>;
}

impl SessionBuilderExt for SessionBuilder {
    fn commit_from_source<S: ModelSource>(self, source: S) -> ort::Result<Session> {
        source.commit_session(self)
    }
}

impl<P: AsRef<Path>> ModelSource for P {
    fn commit_session(&self, builder: SessionBuilder) -> ort::Result<Session> {
        builder.commit_from_file(self.as_ref())
    }
}

pub mod models {
    pub struct ExampleRTDETR;

    impl super::ModelSource for ExampleRTDETR {
        fn commit_session(&self, builder: SessionBuilder) -> ort::Result<Session> {
            builder.commit_from_url("https://kornia.rs/model/rtdetr.onnx")
        }
    }
}

// rtdetr.rs
pub struct RTDETRDetectorBuilder {
    pub source: Box<dyn ModelSource>
}

impl RTDETRDetectorBuilder {
    pub fn with_source<S: ModelSource>(mut self, source: S) -> Self {
        self.source = Box::new(source);
        self
    }
}

impl RTDETRDetector {
    pub fn new(...) -> Result<Self> {
        let session = Session::builder()?
            ...
            .commit_from_source(source)?;
        Ok(Self { session })
    }
}

// user code
let rtdetr = RTDETRDetectorBuilder::with_source(kornia_dnn::models::ExampleRTDETR).build()?;
// or from file
let rtdetr = RTDETRDetectorBuilder::with_source("./my-local-rtdetr.onnx").build()?;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to somehow make ort transparent to the user and avoid them to explicitly pass the ort::ExecutionProvider and have something custom

actually one more idea would be to kinda automatically set based on feature flags?

}

impl RTDETRDetectorBuilder {
/// Creates a new `RTDETRDetectorBuilder` with default settings.
///
/// # Arguments
///
/// * `model_path` - Path to the RT-DETR model file.
/// * `ort_dylib_path` - Path to the ONNX Runtime dynamic library.
///
/// # Returns
///
/// A `Result` containing the `RTDETRDetectorBuilder` if successful, or a `DnnError` if an error occurred.
pub fn new(model_path: PathBuf, ort_dylib_path: PathBuf) -> Result<Self, DnnError> {
Ok(Self {
model_path,
ort_dylib_path,
num_threads: 4,
})
}

/// Sets the number of threads to use for inference.
///
/// # Arguments
///
/// * `num_threads` - The number of threads to use.
///
/// # Returns
///
/// The updated `RTDETRDetectorBuilder` instance.
pub fn with_num_threads(mut self, num_threads: usize) -> Self {
self.num_threads = num_threads;
self
}

/// Builds and returns an `RTDETRDetector` instance.
///
/// # Returns
///
/// A `Result` containing the `RTDETRDetector` if successful, or a `DnnError` if an error occurred.
pub fn build(self) -> Result<RTDETRDetector, DnnError> {
RTDETRDetector::new(self.model_path, self.ort_dylib_path, self.num_threads)
}
}

/// RT-DETR object detector.
///
/// This struct represents an instance of the RT-DETR object detection model.
pub struct RTDETRDetector {
session: Session,
}

impl RTDETRDetector {
edgarriba marked this conversation as resolved.
Show resolved Hide resolved
// TODO: default to hf hub
/// Creates a new `RTDETRDetector` instance.
///
/// # Arguments
///
/// * `model_path` - Path to the RT-DETR model file.
/// * `ort_dylib_path` - Path to the ONNX Runtime dynamic library.
/// * `num_threads` - Number of threads to use for inference.
///
/// # Returns
///
/// A `Result` containing the `RTDETRDetector` if successful, or a `DnnError` if an error occurred.
pub fn new(
model_path: PathBuf,
ort_dylib_path: PathBuf,
num_threads: usize,
) -> Result<Self, DnnError> {
// set the ort dylib path
std::env::set_var("ORT_DYLIB_PATH", ort_dylib_path);

// create the ort session
let session = Session::builder()?
.with_optimization_level(GraphOptimizationLevel::Level3)?
.with_intra_threads(num_threads)?
.commit_from_file(model_path)?;

Ok(Self { session })
}

/// Runs object detection on the given image.
///
/// # Arguments
///
/// * `image` - The input image as an `Image<u8, 3>`.
///
/// # Returns
///
/// A `Result` containing a vector of `Detection` objects if successful, or a `DnnError` if an error occurred.
pub fn run(&self, image: &Image<u8, 3>) -> Result<Vec<Detection>, DnnError> {
// TODO: explore pre-allocating memory for the image
// cast and scale the image to f32
let mut image_hwc_f32 = Image::from_size_val(image.size(), 0.0f32)?;
kornia_image::ops::cast_and_scale(image, &mut image_hwc_f32, 1.0 / 255.)?;

// convert to HWC -> CHW
let image_chw = image_hwc_f32.permute_axes([2, 0, 1]).as_contiguous();

// TODO: create a Tensor::insert_axis in kornia-rs
let image_nchw = Tensor::from_shape_vec(
[
1,
image_chw.shape[0],
image_chw.shape[1],
image_chw.shape[2],
],
image_chw.into_vec(),
CpuAllocator,
)?;

// make the ort tensor
let ort_tensor = ort::Tensor::from_array((image_nchw.shape, image_nchw.into_vec()))?;

// run the model
let outputs = self.session.run(ort::inputs!["input" => ort_tensor]?)?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decahedron1 how could we pre-allocate the output tensor here ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the perfect use case for OutputSelector!


// extract the output tensor
let (out_shape, out_ort) = outputs[0].try_extract_raw_tensor::<f32>()?;

let out_tensor = Tensor::<f32, 3>::from_shape_vec(
[
out_shape[0] as usize,
out_shape[1] as usize,
out_shape[2] as usize,
],
out_ort.to_vec(),
CpuAllocator,
)?;

// parse the output tensor
// we expect the output tensor to be a tensor of shape [1, N, 6]
// where each element is a detection [label, score, x, y, w, h]
let detections = out_tensor
.as_slice()
.chunks_exact(6)
.map(|chunk| Detection {
label: chunk[0] as u32,
score: chunk[1],
x: chunk[2],
y: chunk[3],
w: chunk[4],
h: chunk[5],
})
.collect::<Vec<_>>();

Ok(detections)
}
}
1 change: 1 addition & 0 deletions crates/kornia/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jpegturbo = ["kornia-io/jpegturbo"]

[dependencies]
kornia-core.workspace = true
kornia-dnn.workspace = true
kornia-image.workspace = true
kornia-imgproc.workspace = true
kornia-io = { workspace = true, features = [] }
3 changes: 3 additions & 0 deletions crates/kornia/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#[doc(inline)]
pub use kornia_core as core;

#[doc(inline)]
pub use kornia_dnn as dnn;

#[doc(inline)]
pub use kornia_image as image;

Expand Down
14 changes: 14 additions & 0 deletions examples/rtdetr/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[package]
name = "rtdetr"
version = "0.1.0"
authors = ["Edgar Riba <[email protected]>"]
license = "Apache-2.0"
edition = "2021"
publish = false

[dependencies]
clap = { version = "4.5.4", features = ["derive"] }
ctrlc = "3.4.4"
kornia = { workspace = true, features = ["gstreamer"] }
rerun = "0.18"
tokio = { version = "1" }
28 changes: 28 additions & 0 deletions examples/rtdetr/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
An example showing how to use the RTDETR model with the `kornia::dnn` module and the webcam with the `kornia::io` module with the ability to cancel the feed after a certain amount of time. This example will display the webcam feed in a [`rerun`](https://github.com/rerun-io/rerun) window.

NOTE: This example requires the gstremer backend to be enabled. To enable the gstreamer backend, use the `gstreamer` feature flag when building the `kornia` crate and its dependencies.

## Prerequisites

Maily you need to download onnxruntime from: <https://github.com/microsoft/onnxruntime/releases>

## Usage

```bash
Usage: rtdetr [OPTIONS] --model-path <MODEL_PATH> --ort-dylib-path <ORT_DYLIB_PATH>

Options:
-c, --camera-id <CAMERA_ID> [default: 0]
-f, --fps <FPS> [default: 5]
-m, --model-path <MODEL_PATH>
-o, --ort-dylib-path <ORT_DYLIB_PATH>
-n, --num-threads <NUM_THREADS> [default: 8]
-s, --score-threshold <SCORE_THRESHOLD> [default: 0.75]
-h, --help Print help
```

Example:

```bash
cargo run --bin rtdetr --release -- --camera-id 0 --model-path rtdetr.onnx --ort-dylib-path /path/to/libonnxruntime.so --num-threads 8 --score-threshold 0.75
```
Loading
Loading